master

Conversation 0 Commits 6 Files Changed 5

YanTheKaller commented

Collaborator

There is no content yet.

YanTheKaller added 4 commits

aba1831b30 Various bugs fixes

a9d8428568 Removed open button - it was repeating create button functions

06b559ecbe Sign button is unsensitive when nothing chosen

cb6dfd61a6 If opened repo folder already has repo, its packages will be loaded too

user-166 requested changes

source/ubl-settings-repomanager.c

													
					    GtkWidget *chooser = gtk_file_chooser_dialog_new(LOAD_REPO_LABEL,NULL,GTK_FILE_CHOOSER_ACTION_SELECT_FOLDER,CANCEL_LABEL,GTK_RESPONSE_CANCEL,OPEN_LABEL,GTK_RESPONSE_ACCEPT,NULL);

					    // gtk_file_filter_add_pattern(file_filter,"*db.tar.gz");

					    // gtk_file_filter_set_name(file_filter, "*db.tar.gz");

					    // gtk_file_chooser_add_filter(GTK_FILE_CHOOSER(chooser),file_filter);

user-166 commented

Collaborator

С какой целью фильр типа файла закомментирован?

YanTheKaller commented

Poster

Collaborator

Заменены на отдельную фильтрующую функцию. Убрал

source/ubl-settings-repomanager.c Outdated

													
					    GtkFileFilter *file_filter = gtk_file_filter_new();

					    file_filter = gtk_file_filter_new();

					    gtk_file_filter_add_pattern(file_filter,"*.pkg.tar.*");

					    // gtk_file_filter_add_pattern(file_filter,"*.pkg.tar.*");

user-166 commented

Collaborator

Тут фильтр тоже с какой целью закомментирован?

YanTheKaller commented

Poster

Collaborator

Убрал

YanTheKaller added 1 commit

9904a17b9a Added repos are now save properly

YanTheKaller added 1 commit

914c8584cf Removed comments

user-166 approved these changes

asmeron reviewed

source/ubl-settings-repomanager.c

													
					    gtk_file_filter_set_name(file_filter, "*db.tar.gz");

					    gtk_file_chooser_add_filter(GTK_FILE_CHOOSER(chooser),file_filter);

					    GtkWidget *chooser = gtk_file_chooser_dialog_new(LOAD_REPO_LABEL,NULL,GTK_FILE_CHOOSER_ACTION_SELECT_FOLDER,CANCEL_LABEL,GTK_RESPONSE_CANCEL,OPEN_LABEL,GTK_RESPONSE_ACCEPT,NULL);

					    gtk_window_set_icon_name(GTK_WINDOW(chooser),"com.ublinux.ubl-settings-repomanager");

asmeron commented

Owner

Вынести в переменную внешнее имя иконки.
Старайтесь имена выносить в переменные в шапу в #define , что-бы в случае изменения не бегать по коду и не искать старое имя для замены на новое.

asmeron merged commit a540c87463 into master 2 years ago

asmeron referenced this issue from a commit

Merge pull request 'master' (#30) from YanTheKaller/ubl-settings-repomanager:master into master

Reviewers

user-166 approved these changes

The pull request has been merged as a540c87463.

Sign in to join this conversation.

No Label

No Milestone

No project

No Assignees

3 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Applications/ubl-settings-repomanager#30

master #30

Reviewers